Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file read windows #47876

Merged
merged 1 commit into from May 30, 2018
Merged

Add file read windows #47876

merged 1 commit into from May 30, 2018

Conversation

doesitblend
Copy link
Contributor

@doesitblend doesitblend commented May 29, 2018 •
edited by twangboy

What does this PR do?

Adds the file.read function to the win_file.py module

Related Issue

#45520

Previous Behavior

[root@localhost]# salt '*' file.read "C:\\salt\\conf\\minion"
win2016-2:
    ----------
    file.read:
        'file.read' is not available.

New Behavior

[root@localhost _modules]# salt '*' myfile.read "C:\\salt\\conf\\minion"
win2016-2:
    master: 192.168.60.10
    log_level_logfile: debug
    startup_states: highstate

Tests written?

No

Commits signed with GPG?

No

@ghost ghost self-requested a review May 29, 2018 19:35
@rallytime
Copy link
Contributor

I'm probably not the right person to review this one, so I've removed my review request. :)

@rallytime rallytime removed their request for review May 29, 2018 19:41
twangboy
twangboy requested changes May 29, 2018
View reviewed changes
salt/modules/win_file.py Outdated
@@ -30,13 +30,14 @@
import re # do not remove, used in imported file.py functions
import string # do not remove, used in imported file.py functions
import sys # do not remove, used in imported file.py functions
import io # do not remove, used in imported file.py functions
import fileinput # do not remove, used in imported file.py functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back import io

@doesitblend doesitblend requested a review from a team as a code owner May 29, 2018 21:30
@doesitblend doesitblend changed the base branch from 2018.3 to 2017.7 May 29, 2018 21:30
@rallytime rallytime merged commit b9da4f1 into saltstack:2017.7 May 30, 2018
@rallytime rallytime mentioned this pull request May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doesitblend @rallytime @twangboy